diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-10-29 20:55:17 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-10-29 20:55:17 +0000 |
| commit | 2a5c694ead001e072b2e243e79f17f296d18c898 (patch) | |
| tree | 797e5386d513912d7596e9d1192a8a2978208d22 | |
| parent | 69066ab61e2f07c33b3de37720ef22d64f8e3771 (diff) | |
| download | pdfium-2a5c694ead001e072b2e243e79f17f296d18c898.tar.xz | |
Test CFX_V8::ToByteString() in cfx_v8_unittest.cpp.
Although currently only called from XFA, this is a reasonable part
of the CFX_V8 interface, and should be built/tested in all cases.
Change-Id: I6401b22d300cac47aac13cb16648ab4babd4432b
Reviewed-on: https://pdfium-review.googlesource.com/c/44790
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
| -rw-r--r-- | fxjs/cfx_v8_unittest.cpp | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/fxjs/cfx_v8_unittest.cpp b/fxjs/cfx_v8_unittest.cpp index f6051ad935..f8e0be654b 100644 --- a/fxjs/cfx_v8_unittest.cpp +++ b/fxjs/cfx_v8_unittest.cpp @@ -38,6 +38,7 @@ TEST_F(FXV8UnitTest, EmptyLocal) { EXPECT_FALSE(cfx_v8()->ToBoolean(empty)); EXPECT_EQ(0, cfx_v8()->ToInt32(empty)); EXPECT_EQ(0.0, cfx_v8()->ToDouble(empty)); + EXPECT_EQ("", cfx_v8()->ToByteString(empty)); EXPECT_EQ(L"", cfx_v8()->ToWideString(empty)); EXPECT_TRUE(cfx_v8()->ToObject(empty).IsEmpty()); EXPECT_TRUE(cfx_v8()->ToArray(empty).IsEmpty()); @@ -52,6 +53,7 @@ TEST_F(FXV8UnitTest, NewNull) { EXPECT_FALSE(cfx_v8()->ToBoolean(nullz)); EXPECT_EQ(0, cfx_v8()->ToInt32(nullz)); EXPECT_EQ(0.0, cfx_v8()->ToDouble(nullz)); + EXPECT_EQ("null", cfx_v8()->ToByteString(nullz)); EXPECT_EQ(L"null", cfx_v8()->ToWideString(nullz)); EXPECT_TRUE(cfx_v8()->ToObject(nullz).IsEmpty()); EXPECT_TRUE(cfx_v8()->ToArray(nullz).IsEmpty()); @@ -66,6 +68,7 @@ TEST_F(FXV8UnitTest, NewUndefined) { EXPECT_FALSE(cfx_v8()->ToBoolean(undef)); EXPECT_EQ(0, cfx_v8()->ToInt32(undef)); EXPECT_TRUE(std::isnan(cfx_v8()->ToDouble(undef))); + EXPECT_EQ("undefined", cfx_v8()->ToByteString(undef)); EXPECT_EQ(L"undefined", cfx_v8()->ToWideString(undef)); EXPECT_TRUE(cfx_v8()->ToObject(undef).IsEmpty()); EXPECT_TRUE(cfx_v8()->ToArray(undef).IsEmpty()); @@ -80,6 +83,7 @@ TEST_F(FXV8UnitTest, NewBoolean) { EXPECT_TRUE(cfx_v8()->ToBoolean(boolz)); EXPECT_EQ(1, cfx_v8()->ToInt32(boolz)); EXPECT_EQ(1.0, cfx_v8()->ToDouble(boolz)); + EXPECT_EQ("true", cfx_v8()->ToByteString(boolz)); EXPECT_EQ(L"true", cfx_v8()->ToWideString(boolz)); EXPECT_TRUE(cfx_v8()->ToObject(boolz).IsEmpty()); EXPECT_TRUE(cfx_v8()->ToArray(boolz).IsEmpty()); @@ -88,6 +92,7 @@ TEST_F(FXV8UnitTest, NewBoolean) { EXPECT_FALSE(cfx_v8()->ToBoolean(boolz)); EXPECT_EQ(0, cfx_v8()->ToInt32(boolz)); EXPECT_EQ(0.0, cfx_v8()->ToDouble(boolz)); + EXPECT_EQ("false", cfx_v8()->ToByteString(boolz)); EXPECT_EQ(L"false", cfx_v8()->ToWideString(boolz)); EXPECT_TRUE(cfx_v8()->ToObject(boolz).IsEmpty()); EXPECT_TRUE(cfx_v8()->ToArray(boolz).IsEmpty()); @@ -102,6 +107,7 @@ TEST_F(FXV8UnitTest, NewNumber) { EXPECT_TRUE(cfx_v8()->ToBoolean(num)); EXPECT_EQ(42, cfx_v8()->ToInt32(num)); EXPECT_EQ(42.1, cfx_v8()->ToDouble(num)); + EXPECT_EQ("42.1", cfx_v8()->ToByteString(num)); EXPECT_EQ(L"42.1", cfx_v8()->ToWideString(num)); EXPECT_TRUE(cfx_v8()->ToObject(num).IsEmpty()); EXPECT_TRUE(cfx_v8()->ToArray(num).IsEmpty()); @@ -116,6 +122,7 @@ TEST_F(FXV8UnitTest, NewString) { EXPECT_TRUE(cfx_v8()->ToBoolean(str)); EXPECT_EQ(123, cfx_v8()->ToInt32(str)); EXPECT_EQ(123, cfx_v8()->ToDouble(str)); + EXPECT_EQ("123", cfx_v8()->ToByteString(str)); EXPECT_EQ(L"123", cfx_v8()->ToWideString(str)); EXPECT_TRUE(cfx_v8()->ToObject(str).IsEmpty()); EXPECT_TRUE(cfx_v8()->ToArray(str).IsEmpty()); @@ -130,6 +137,7 @@ TEST_F(FXV8UnitTest, NewDate) { EXPECT_TRUE(cfx_v8()->ToBoolean(date)); EXPECT_EQ(1111111111, cfx_v8()->ToInt32(date)); EXPECT_EQ(1111111111.0, cfx_v8()->ToDouble(date)); + EXPECT_NE("", cfx_v8()->ToByteString(date)); // exact format varies. EXPECT_NE(L"", cfx_v8()->ToWideString(date)); // exact format varies. EXPECT_TRUE(cfx_v8()->ToObject(date)->IsObject()); EXPECT_TRUE(cfx_v8()->ToArray(date).IsEmpty()); |