diff options
| author | Tom Sepez <tsepez@chromium.org> | 2018-06-04 19:44:37 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-06-04 19:44:37 +0000 |
| commit | 36aae4fc09a353e01738bf0bbc302a21ba21ed07 (patch) | |
| tree | 2d9d1cbe2f7c8eeed7aff9fc63a8f8300a25d6b7 /fxjs/cjs_app.h | |
| parent | 9d3fb11a985a8f2aefbf361c0030c7bce2248b8e (diff) | |
| download | pdfium-36aae4fc09a353e01738bf0bbc302a21ba21ed07.tar.xz | |
Make CJS_Objects track CJS_Runtime (and hence the document itself)
Precursor to removing some more v8::Context slot dependency.
There's a cost to maintaining the set of observers, but since these
objects are tied to V8 lifetimes, not C++ lifetimes, we want to be
very wary of the document going away unexpectedly.
Change-Id: I579f58a460aa50b88cb861227c9aca9a8a83ce12
Reviewed-on: https://pdfium-review.googlesource.com/33471
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'fxjs/cjs_app.h')
| -rw-r--r-- | fxjs/cjs_app.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fxjs/cjs_app.h b/fxjs/cjs_app.h index e195c6db24..3c3a129641 100644 --- a/fxjs/cjs_app.h +++ b/fxjs/cjs_app.h @@ -20,7 +20,7 @@ class CJS_App : public CJS_Object { public: static void DefineJSObjects(CFXJS_Engine* pEngine); - explicit CJS_App(v8::Local<v8::Object> pObject); + CJS_App(v8::Local<v8::Object> pObject, CJS_Runtime* pRuntime); ~CJS_App() override; void TimerProc(GlobalTimer* pTimer); @@ -153,8 +153,8 @@ class CJS_App : public CJS_Object { void RunJsScript(CJS_Runtime* pRuntime, const WideString& wsScript); void ClearTimerCommon(CJS_Runtime* pRuntime, v8::Local<v8::Value> param); - bool m_bCalculate; - bool m_bRuntimeHighLight; + bool m_bCalculate = true; + bool m_bRuntimeHighLight = false; std::set<std::unique_ptr<GlobalTimer>> m_Timers; }; |