diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-05-17 13:53:52 +0000 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-05-17 13:53:52 +0000 |
| commit | dc5d88bcebbeeb696b405464e901add55d1efaf7 (patch) | |
| tree | 54bc913015ea4d08b9fe46997f25a3153cbc70d7 /fxjs/ijs_event_context.h | |
| parent | db3c6cefceddf25c25f1205d7b633f09e873bf98 (diff) | |
| download | pdfium-dc5d88bcebbeeb696b405464e901add55d1efaf7.tar.xz | |
Convert JS execute methods to return Optional<IJS_Runtime::JS_Error>
This CL changes several of the JS execution methods to to return an
Optional<IJS_Runtime::JS_Error> instead of a bool with a WideString
out param.
The IJS_Runtime::JS_Error will contain the line, column and exception message
if an error occurs during execution.
Change-Id: I37785ae6cd133a4c94ad8d25289473600b8a5d19
Reviewed-on: https://pdfium-review.googlesource.com/32614
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Diffstat (limited to 'fxjs/ijs_event_context.h')
| -rw-r--r-- | fxjs/ijs_event_context.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fxjs/ijs_event_context.h b/fxjs/ijs_event_context.h index 6050d65eca..8317bc29be 100644 --- a/fxjs/ijs_event_context.h +++ b/fxjs/ijs_event_context.h @@ -9,6 +9,8 @@ #include "core/fxcrt/fx_string.h" #include "core/fxcrt/fx_system.h" +#include "fxjs/ijs_runtime.h" +#include "third_party/base/optional.h" class CPDF_Bookmark; class CPDF_FormField; @@ -22,7 +24,8 @@ class IJS_EventContext { public: virtual ~IJS_EventContext() {} - virtual bool RunScript(const WideString& script, WideString* info) = 0; + virtual Optional<IJS_Runtime::JS_Error> RunScript( + const WideString& script) = 0; virtual void OnApp_Init() = 0; |