diff options
| author | Dan Sinclair <dsinclair@chromium.org> | 2018-01-03 09:44:28 -0500 |
|---|---|---|
| committer | Chromium commit bot <commit-bot@chromium.org> | 2018-01-08 14:52:51 +0000 |
| commit | 5553d8b11634935c34e7774325eda6afd61c8f56 (patch) | |
| tree | a33d4014b3c7f1ef88bf84e3ec3ef05a53af1b7f /testing/embedder_test.h | |
| parent | 5183e8679844eeff2c5dda2a2e02762487429a1f (diff) | |
| download | pdfium-5553d8b11634935c34e7774325eda6afd61c8f56.tar.xz | |
Initialize V8 once in embedder tests
This CL moves the initialization of the V8 platform to happen in the
GTest environment so it's only run once. This takes the
CFXJSE_FormCalcContextEmbedderTest Debug time from ~25s to ~19s on my
local machine.
Bug: pdfium:928
Change-Id: Ie8c27606721e7056de42e7d9474b0621f1e7212f
Reviewed-on: https://pdfium-review.googlesource.com/22070
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Diffstat (limited to 'testing/embedder_test.h')
| -rw-r--r-- | testing/embedder_test.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/testing/embedder_test.h b/testing/embedder_test.h index 03155793c5..8da1643824 100644 --- a/testing/embedder_test.h +++ b/testing/embedder_test.h @@ -167,9 +167,6 @@ class EmbedderTest : public ::testing::Test, FPDF_FORMHANDLE form_handle_; FPDF_AVAIL avail_; FPDF_FILEACCESS file_access_; // must outlive avail_. -#ifdef PDF_ENABLE_V8 - v8::Platform* platform_; -#endif // PDF_ENABLE_V8 void* external_isolate_; TestLoader* loader_; size_t file_length_; |